Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve button state download engine variant #4444

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jan 13, 2025

Describe Your Changes

This pull request includes several updates to the web/screens/Settings/Engines/Settings.tsx file. The changes primarily focus on improving error handling, ensuring immutability, and cleaning up the code by removing unused imports.

Error Handling and Immutability Improvements:

  • Added error logging when a variant is not found during the engine installation process.
  • Updated the setInstallingEngines function to clone the existing Map to ensure immutability before making modifications.

Code Cleanup:

  • Removed the unused Trash2Icon import from lucide-react.
  • Removed the unused uninstallEngine import from @/hooks/useEngineManagement.

Minor Adjustments:

  • Added a newline for better readability in the return statement of the EngineSettings component.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: chore Maintenance, operational label Jan 13, 2025
@urmauur urmauur requested a review from louis-jan January 13, 2025 14:53
@urmauur urmauur self-assigned this Jan 13, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 68.61%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 548dd6c into dev Jan 13, 2025
21 checks passed
@urmauur urmauur deleted the chore/button-state-update-download-local-engine branch January 13, 2025 15:13
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 13, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants