Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts support version patch and restore support for all platforms #4429

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

bxdoan
Copy link
Contributor

@bxdoan bxdoan commented Jan 10, 2025

Describe Your Changes

  • jq and tr applications doesn't support for Window when build or dev for electron app, so I add scripts to do it for all platforms

electron/package.json Outdated Show resolved Hide resolved
@louis-jan
Copy link
Contributor

Thanks for contributing and helping with dev-ex enhancement.

electron/package.json Outdated Show resolved Hide resolved
@bxdoan
Copy link
Contributor Author

bxdoan commented Jan 13, 2025

Hi @louis-jan , I removed scripts and used run-script-os

electron/package.json Outdated Show resolved Hide resolved
electron/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit b6c1fb5 into janhq:dev Jan 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants