Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync release 0.5.13 into dev #4408

Merged
merged 13 commits into from
Jan 6, 2025
Merged

Sync release 0.5.13 into dev #4408

merged 13 commits into from
Jan 6, 2025

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

This PR syncs the latest changes from the hotfix release 0.5.13 into the dev branch

Changes made

This pull request includes various updates to the inference-cortex-extension and some minor fixes in the web application. The most important changes involve updating the engine version, adding a new setting for CPU threads, and fixing a parameter name in the web hooks.

Updates to inference-cortex-extension:

  • Updated ENGINE_VERSION to 0.1.42-hotfix in download.bat, download.sh, and rollup.config.ts to ensure the correct version is used for downloads and configurations. [1] [2] [3]
  • Added a new setting for cpu_threads in default_settings.json to allow specifying the number of CPU threads to use.
  • Updated Settings enum and JanInferenceCortexExtension class in index.ts to include and handle the new cpu_threads setting. [1] [2] [3] [4] [5]

Fixes in the web application:

  • Corrected the parameter name from token_limit to max_tokens in useCreateNewThread.ts to ensure the correct parameter is used.
  • Removed unnecessary GPU list length check in Settings/Advanced/index.tsx for better compatibility with non-Mac systems.

louis-jan and others added 12 commits December 31, 2024 19:25
…intel-machines

fix: bump llama.cpp engine hotfix version to address model load issue on some MacOS Intel machines
…ption

fix: should not disable Vulkan support option
…nsion-settings

chore: add cpu_threads settings in cortex extension
* fux: send event opt out from button deny

* chore: fix copy

* chore: update placeholder
…rt-when-users-create-new-thread

fix: max_tokens revert back to 8192 automatically when creating a new thread
@louis-jan louis-jan requested a review from urmauur January 6, 2025 13:19
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Barecheck - Code coverage report

Total: 68.61%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/hooks/useCreateNewThread.ts139-140, 142-143, 150-151, 162, 171, 208, 212, 214
web/screens/Settings/Advanced/index.tsx81, 90, 103, 121-124, 134, 138-140, 142, 188-191, 198-199, 201, 205-206, 208, 210-211, 214, 261, 293-296, 302-304, 311-314, 353, 376, 385, 434, 515, 520

@louis-jan louis-jan merged commit b4d2176 into dev Jan 6, 2025
24 of 30 checks passed
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants