chore: reduce test build steps #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiento09
approved these changes
Jan 2, 2025
Barecheck - Code coverage reportTotal: 68.71%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Disable playwright reporter, now it's running on Github Runner - No network access to the portal accepted. Also windows-build job should use windows-latest runner
Self Checklist
This pull request includes changes to the
.github/workflows/jan-electron-linter-and-test.ymlandelectron/playwright.config.tsfiles. The changes primarily involve commenting out sections of code related to configuring the report portal and updating the workflow conditions.Changes to
.github/workflows/jan-electron-linter-and-test.yml:Config report portalsteps across different job sections to disable the configuration of the report portal. [1] [2] [3] [4]ifcondition for thetest-on-windows-prjob to includeworkflow_dispatchevents and changed the runner towindows-latest.Changes to
electron/playwright.config.ts:reporterconfiguration to disable HTML reporting for Playwright tests.