Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if the default engine isn't installed, the app should reset it #4379

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jan 1, 2025

Describe Your Changes

There would be an issue where the app wouldn't reset the default engine if the user manually modifies it or updates from a hotfix version. This would break the default settings, and users would have to manually update the engine in the settings. This isn't a good UX, they should have it configured properly on launch.

On launch:
Check default variant -> Get installed variants -> If installed variants are not including default variant it would not work -> Reset default variant to bundled version.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

This pull request includes updates to the extensions/engine-management-extension to improve version handling and remove unnecessary code. The most important changes include updating the Cortex engine version, modifying the logic for checking installed engines, and removing the compareVersions method.

Version update:

Logic improvement:

Code simplification:

@github-actions github-actions bot added the type: bug Something isn't working label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Barecheck - Code coverage report

Total: 68.71%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

github-actions bot commented Jan 1, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-jan louis-jan merged commit ed3bdf4 into dev Jan 1, 2025
21 checks passed
@louis-jan louis-jan deleted the fix/should-reset-default-engine-on-unavailable branch January 1, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants