Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve development dev-ex with auto extensions migration #4370

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Dec 31, 2024

Describe Your Changes

It was a nightmare to update extensions on the development environment (dev), where we were unaware of when any extension was updated since the app version was fixed in that environment. This dev-ex enhancement aims to address these issues by:

  1. Automatically migrating extensions on dev (any new update will be applied automatically when the app is run).
  2. Enhancing concurrent process management and log output. Previously, developers had to close the app window and terminate or kill the terminal process, and it was difficult to determine which log belonged to which process. Now, simply closing the app window will kill the Electron process, and vice versa. Log outputs will be highlighted with a different color
    and prefix to indicate the source of the log.

Everything is just yarn dev or make dev

CleanShot 2024-12-31 at 12 15 38@2x

The build time for CI has been reduced by 40 seconds more.

Changes made

This pull request includes changes to the dev scripts in both electron/package.json and package.json. These changes aim to enhance the development workflow by adding version management and improving the concurrently command.

Improvements to development workflow:

  • electron/package.json: Added version-patch and version-restore scripts to handle versioning during development and modified the dev script to include these new scripts.
  • package.json: Enhanced the dev script to use concurrently with named processes and color coding, improving readability and management of concurrent tasks.

@louis-jan louis-jan requested a review from urmauur December 31, 2024 05:33
@github-actions github-actions bot added the type: chore Maintenance, operational label Dec 31, 2024
Copy link
Contributor

github-actions bot commented Dec 31, 2024

Barecheck - Code coverage report

Total: 68.72%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-jan louis-jan merged commit 0be5349 into dev Dec 31, 2024
9 checks passed
@louis-jan louis-jan deleted the chore/enhance-dev-ex branch December 31, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants