Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: update ui delete engine with modal confirmation #4359

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 30, 2024

Describe Your Changes

Screenshot 2024-12-30 at 18 06 40

Changes in web/screens/Settings/Engines/Settings.tsx:

  • Import of a new module: import DeleteEngineVariant from './DeleteEngineVariant'.
  • Replaced a block of code that used to render a Button with logic for uninstalling an engine variant with the DeleteEngineVariant component. The DeleteEngineVariant component is now rendered instead when an engine variant is installed.

These changes suggest a refactor or modularization of the code related to uninstalling engine variants, possibly for better maintainability or reuse. The changes to yarn.lock denote an updated package or a repackaging with new checksum validations.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: enhancement Improves a current feature label Dec 30, 2024
@urmauur urmauur added this to the v0.5.13 milestone Dec 30, 2024
@urmauur urmauur requested a review from louis-jan December 30, 2024 11:07
@urmauur urmauur self-assigned this Dec 30, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 68.61%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit fc7a771 into dev Dec 31, 2024
19 checks passed
@urmauur urmauur deleted the enahancement/ui-delete-engine-variant branch December 31, 2024 03:10
@imtuyethan imtuyethan modified the milestones: v0.5.13, v0.5.14 Jan 2, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants