Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button state reset on switching models #4356

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

This PR resolved the issue where switching to a new button would cause the stop button to disappear.

Changes made

This pull request includes several changes to improve state management and streamline the codebase in the web directory. The changes focus on the use of Jotai atoms for state management, the addition of new utility atoms, and the removal of redundant code.

State Management Improvements:

Utility Atom Additions:

Code Simplification:

Test Updates:

@louis-jan louis-jan changed the base branch from dev to main December 30, 2024 07:26
@louis-jan louis-jan changed the title Fix/button state reset on switching models fix: button state reset on switching models Dec 30, 2024
@github-actions github-actions bot added the type: bug Something isn't working label Dec 30, 2024
@louis-jan louis-jan merged commit 81ad90b into main Dec 30, 2024
14 of 16 checks passed
@louis-jan louis-jan deleted the fix/button-state-reset-on-switching-models branch December 30, 2024 07:30
@github-actions github-actions bot added this to the v0.5.12 milestone Dec 30, 2024
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants