Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't stop inference and hide the stop button when creating a new thread #4354

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

This is to fix the issue where stop button is disabled when creating a new thread

Changes made

This pull request includes changes to the web/hooks/useCreateNewThread.ts file, focusing on code cleanup and removal of unused imports and variables. The most important changes include the removal of the useActiveModel import and associated variables and functions.

Code cleanup and simplification:

  • Removed unused import useActiveModel from web/hooks/useCreateNewThread.ts.
  • Removed the setIsGeneratingResponse variable and the stopInference function from the useCreateNewThread function in web/hooks/useCreateNewThread.ts.

@louis-jan louis-jan requested a review from urmauur December 30, 2024 05:08
@github-actions github-actions bot added the type: chore Maintenance, operational label Dec 30, 2024
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-jan louis-jan merged commit 16dce88 into main Dec 30, 2024
17 of 21 checks passed
@louis-jan louis-jan deleted the fix/stop-button-on-creating-thread branch December 30, 2024 05:32
@github-actions github-actions bot added this to the v0.5.12 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants