Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send message button state reset on stop #4341

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

This PR addresses the issue where stopping a model mid-generation can cause the stop button to remain in the generating state.

Changes made

This pull request includes changes to improve the handling of thread states and model management in the application. The key changes involve adding a new atom to reset the thread waiting for response state and updating the useActiveModel hook to incorporate this reset functionality.

Improvements to thread state management:

UI updates:

@louis-jan louis-jan requested a review from urmauur December 26, 2024 12:08
@github-actions github-actions bot added the type: bug Something isn't working label Dec 26, 2024
Copy link
Contributor

github-actions bot commented Dec 26, 2024

@louis-jan louis-jan merged commit c77275a into main Dec 26, 2024
9 checks passed
@louis-jan louis-jan deleted the fix/stop-button-state branch December 26, 2024 13:12
@github-actions github-actions bot added this to the v0.5.12 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants