fix: send message button state reset on stop #4341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR addresses the issue where stopping a model mid-generation can cause the stop button to remain in the generating state.
Changes made
This pull request includes changes to improve the handling of thread states and model management in the application. The key changes involve adding a new atom to reset the thread waiting for response state and updating the
useActiveModel
hook to incorporate this reset functionality.Improvements to thread state management:
web/helpers/atoms/Thread.atom.ts
: AddedresetThreadWaitingForResponseAtom
to reset the waiting for response state of threads.web/hooks/useActiveModel.ts
: ImportedresetThreadWaitingForResponseAtom
and used it in theuseActiveModel
hook to reset the thread waiting for response state when stopping a model. [1] [2] [3] [4]UI updates:
web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx
: Simplified the condition for displaying the chat input button by removing the check for the last message's status.