-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: local engine management #4334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 68.61%Your code coverage diff: 0.05% ▴ Uncovered files and lines
|
urmauur
force-pushed
the
feat/local-engine-management
branch
from
December 26, 2024 06:48
13d1ebf
to
a1fc178
Compare
louis-jan
force-pushed
the
feat/local-engine-management
branch
from
December 29, 2024 10:49
e45e0eb
to
8b5bd89
Compare
louis-jan
had a problem deploying
to
production
December 29, 2024 10:49 — with
GitHub Actions
Failure
louis-jan
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
louis-jan
had a problem deploying
to
production
December 30, 2024 09:49 — with
GitHub Actions
Failure
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Jan needs a user interface to manage Cortex.cpp engines and their variants. This includes viewing installed engines, managing engine installations, and controlling engine settings through a unified interface.
Fixes Issues
Changes made
This pull request introduces a new engine management extension and updates the workflow configurations. The most significant changes include the addition of the engine management extension, updates to the Node.js version in the workflow, and modifications to the existing code to integrate the new extension.
Engine Management Extension:
EngineManagementExtension
class to manage engine configurations and operations (core/src/browser/extensions/enginesManagement.ts
).Engines
,EngineVariant
,DefaultEngineVariant
, andEngineReleased
(core/src/types/engine/index.ts
).core/src/browser/extensions/index.ts
,core/src/types/index.ts
). [1] [2]extensions/engine-management-extension/package.json
,extensions/engine-management-extension/rolldown.config.mjs
). [1] [2]JSONEngineManagementExtension
class to provide functionality for managing engines (extensions/engine-management-extension/src/index.ts
).Workflow Updates:
.github/workflows/jan-electron-linter-and-test.yml
). [1] [2]Code Integration:
Engine
toExtensionTypeEnum
to support the new extension (core/src/browser/extension.ts
).extensions/engine-management-extension/jest.config.js
,extensions/engine-management-extension/src/error.ts
). [1] [2]extensions/engine-management-extension/src/node/index.test.ts
). [1] [2] [3] [4] [5] [6] [7] [8]