Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app picks model automatically edge cases #4322

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

Fixed an issue where deleted models were not handled gracefully. However, there are still edge cases where users could change tool settings or delete a new thread, causing the app to automatically assign a new model to older threads with deleted models.

CleanShot 2024-12-23 at 15 19 28

Fixes Issues

Changes made

This pull request includes several changes to improve the handling of model selection and thread management in the web application. The most important changes include refactoring the code to simplify model selection and updating the thread deletion logic to use a new hook.

Improvements to model selection:

Enhancements to thread management:

@github-actions github-actions bot added the type: bug Something isn't working label Dec 23, 2024
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

Copy link
Contributor

@louis-jan louis-jan merged commit df1c465 into main Dec 23, 2024
21 checks passed
@louis-jan louis-jan deleted the fix/app-picks-model-automatically-edge-cases branch December 23, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants