fix: fetch threads and messages without limiting #4304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR resolved an issue where threads and messages were being truncated due to the default API limit.
Changes made
The code changes in this pull request involve modifying API requests to include a
limit=-1
query parameter. This change is applied across multiple methods to ensure that the API returns all available data without limiting the number of results. The specific changes are as follows:In
extensions/conversational-extension/src/index.ts
:listThreads
: Changed the endpoint to${API_URL}/v1/threads?limit=-1
.listMessages
: Changed the endpoint to${API_URL}/v1/threads/${threadId}/messages?order=asc&limit=-1
.getThreadAssistant
: Changed the endpoint to${API_URL}/v1/assistants/${threadId}?limit=-1
.In
extensions/model-extension/src/cortex.ts
:getModels
: Changed the endpoint to${API_URL}/v1/models?limit=-1
.These changes ensure that the API requests fetch all threads, messages, assistants, and models without any limits.