fix: empty tooltip on attachment icon, also fix z-index #4290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
In
web/screens/Hub/ModelList/ModelHeader/index.tsx
:z-50
class was removed from theButton
component. This class might have been related to the z-index, and its removal suggests a possible simplification or a fix for a styling issue.In
web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx
:isModelSupportRagAndTools
constant has been refined to focus solely on the result ofisLocalEngine(selectedModel?.engine as InferenceEngine)
. Previously, it also checked ifselectedModel?.engine === InferenceEngine.openai
.disabled
property of certain elements has been updated to disable the button if!isModelSupportRagAndTools
instead ofisModelSupportRagAndTools
.isModelSupportRagAndTools
isfalse
, reflecting conditions under which interaction should be permissible.isModelSupportRagAndTools
istrue
before executing the file input click and closing the attachment menus. This check prevents actions when the conditions do not support them.These changes aim to clean up the code, refactor conditions for clarity, and ensure user interfaces respond correctly to model support conditions.
Fixes Issues
Self Checklist