Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix issue with duplicate events on Enter key press during CJK character composition in chat input #4268

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

cuhong
Copy link
Contributor

@cuhong cuhong commented Dec 12, 2024

Describe Your Changes

  • Resolve problem where pressing Enter triggers events twice: once for the composed string and once for the composing character.
  • Ensure proper handling of composition events for Chinese, Japanese, and Korean input.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from urmauur December 12, 2024 07:34
@urmauur
Copy link
Member

urmauur commented Dec 12, 2024

LGTM

@louis-jan
Copy link
Contributor

louis-jan commented Dec 16, 2024

Hi @cuhong Could you please help resolve the linter issue so that we can proceed?

…Prettier standard

- Refactored condition in `onKeyDown` function for better readability.
- Resolved Prettier lint error by adding line breaks and proper indentation.
@cuhong
Copy link
Contributor Author

cuhong commented Dec 16, 2024

Hi @cuhong Could you please help resolve the linter issue so that we can proceed?

Sure, I've addressed the linter issue.

@louis-jan louis-jan merged commit c166f7c into janhq:dev Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants