fix: 4209 - Inconsistent max tokens value persistence #4213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR addresses an issue where selecting the max_tokens parameter in the thread.json file doesn’t get updated when the model is changed.
Fixes Issues
Changes made
The code change involves adjustments to how model parameters are handled in two different files:
ModelDropdown/index.tsx
anduseCreateNewThread.ts
.ModelDropdown/index.tsx Changes:
overriddenSettings
logic is replaced withoverriddenParameters
.defaultContextLength
variable is defined, which chooses the minimum between 8192 and the model'sctx_len
setting (defaulting to 8192 if not specified).overriddenParameters
object now includes bothctx_len
andmax_tokens
, both set to this newdefaultContextLength
.useCreateNewThread.ts Changes:
ModelDropdown
, adefaultContextLength
variable is introduced.overriddenSettings
object now consistently uses thisdefaultContextLength
forctx_len
.overriddenParameters
object is reconstructed to setmax_tokens
using the samedefaultContextLength
.Overall, the changes standardize how
ctx_len
andmax_tokens
are determined and used, defaulting these settings to a maximum of 8192.