fix: 4165 - Refactor message builder to avoid sending empty messages #4199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist
The code changes involve refactoring the function
normalizeMessages
and its integration within the system:Removal from
useSendChatMessage.ts
:normalizeMessages
function and theStack
import were removed fromuseSendChatMessage.ts
. This function was previously responsible for ensuring consecutive messages from the same role (e.g., User or Assistant) were separated by an empty message. The feature was meant to meet specific requirements of some models.normalizeMessages
was also removed from theresendChatMessage
function, meaning normalization is no longer performed directly there.Integration into
messageRequestBuilder.ts
:normalizeMessages
was moved intoMessageRequestBuilder
class inmessageRequestBuilder.ts
. This function maintains the same logic to avoid consecutive messages of the same role by inserting a dummy message.build()
function call, ensuring the message list is normalized whenever aMessageRequest
is built.By consolidating the
normalizeMessages
logic within theMessageRequestBuilder
, the process of managing message roles is now contained within the request-building phase, promoting better cohesion and separability within the codebase.