fix: 4094 - gpu mode toggle on by default but not affect for the first time launch #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Nov 26, 2024
Barecheck - Code coverage reportTotal: 69.18%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
|
Feature build: |
louis-jan
deleted the
fix/4094-gpu-mode-not-working-after-first-factory-reset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR addresses an issue where the app fails to configure a new GPU variant update after detecting GPU information in the background during the first launch. The app still runs in CPU mode even when the GPU toggle is enabled in the settings.
Fixes Issues
The first attempt it sets CPU engine variant, then it switched to GPU engine variant
GPU is used without additional settings
Changes made
The code changes introduce the following updates across multiple files:
inference-cortex-extension/src/index.ts:AppConfigurationEventNamefrom@janhq/core.AppConfigurationEventName.OnConfigurationUpdatethat updates the system's run mode when settings change.ModelEvent.OnModelStoppedwhen a WebSocket connection is closed.monitoring-extension/src/index.ts:AppConfigurationEventNameandeventsfrom@janhq/core.AppConfigurationEventName.OnConfigurationUpdatefrom within theonLoadmethod to notify of configuration updates post Nvidia info update.The main focus of the changes seems to be around monitoring and responding to configuration changes and handling WebSocket connectivity events more robustly.