fix: 3986 - invalid request should show clear error message #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 69.18%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
urmauur
approved these changes
Nov 26, 2024
louis-jan
force-pushed
the
fix/invalid-request-should-not-show-invalid-api-key
branch
from
f6bbc34 to
60a888c
Compare
louis-jan
deleted the
fix/invalid-request-should-not-show-invalid-api-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
The error message for an invalid request is not handled correctly. Instead of displaying a clear error message from the provider, it prompts users about an invalid API key error.
Fixes Issues
Changes made
The provided
git diffshows a modification in theindex.tsxfile located in theweb/containers/ErrorMessagedirectory. Specifically, the change involves removing a single case from a switch statement. The case that has been removed is:This change means that the
ErrorMessagecomponent will no longer handle theInvalidRequestErrorby displaying a specific error message (i.e., an invalid API key error), which was part of the switch statement before this modification.