Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model dropdown should show recommended models to download #3742

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

There was an issue where recommended models weren't expanding to download, and this PR is just to fix that. This will be changed to cortex after 0.5.5

Screenshots

Local models section is expanded by default
21636

Code changes

  1. Model.atom.test.ts:

    • In the test for 'showEngineListModelAtom', the expected initial value has been changed from an empty array ([]) to an array containing 'nitro' (['nitro']).
  2. Model.atom.ts:

    • The import statement has been updated to include 'InferenceEngine' from '@janhq/core'.
    • The 'showEngineListModelAtom' has been modified to initialize with [InferenceEngine.nitro] instead of an empty array.

These changes suggest that the 'showEngineListModelAtom' is now being initialized with a default value of 'nitro' as the inference engine, rather than starting empty. The test file has been updated to reflect this change in the expected initial state.

@github-actions github-actions bot added the type: bug Something isn't working label Sep 30, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 65.54%

Your code coverage diff: 0.01% ▴

✅ All code changes are covered

@louis-menlo louis-menlo merged commit 7c63914 into dev Sep 30, 2024
11 checks passed
@louis-menlo louis-menlo deleted the fix/should-expand-available-to-download-models branch September 30, 2024 07:34
@github-actions github-actions bot added this to the v0.5.5 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants