Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: does not register global shortcut when quick ask is disabled #2592

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: does not register global shortcut when quick ask is disabled #2592

merged 1 commit into from
Apr 3, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Fixed an issue: The app registers a global shortcut even when it's not enabled.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Apr 3, 2024
@louis-jan louis-jan merged commit 8926c13 into dev Apr 3, 2024
6 checks passed
@louis-jan louis-jan deleted the fix/does-not-register-global-shortcut-on-quick-ask-disabled branch April 3, 2024 06:56
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@urmauur urmauur Awaiting requested review from urmauur

@Inchoker Inchoker Awaiting requested review from Inchoker

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @namchuai