Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor docker compose #2531

Merged
merged 3 commits into from
Mar 29, 2024
Merged

chore: Refactor docker compose #2531

merged 3 commits into from
Mar 29, 2024

Conversation

hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Mar 29, 2024 •
edited
Loading

Describe Your Changes

  • Split docker compose dev with local build and docker compose with prebuilt image on ghcr

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiro-v hiro-v requested a review from hiento09 March 29, 2024 02:09
@hiro-v hiro-v self-assigned this Mar 29, 2024
@github-actions github-actions bot added the type: chore Maintenance, operational label Mar 29, 2024
hiento09
hiento09 reviewed Mar 29, 2024
View reviewed changes
docker-compose-dev.yml Outdated Show resolved Hide resolved
@hiro-v hiro-v mentioned this pull request Mar 29, 2024
Merged
5 tasks
hiento09
hiento09 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiro-v hiro-v merged commit e60807f into dev Mar 29, 2024
@hiro-v hiro-v deleted the chore/refactor_docker_compose branch March 29, 2024 02:50
@github-actions github-actions bot added this to the v0.4.11 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees

@hiro-v hiro-v

Labels
type: chore Maintenance, operational
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.
2 participants
@hiro-v @hiento09