-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamically register extension settings #2494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-jan
reviewed
Mar 27, 2024
namchuai
force-pushed
the
feat/extension-setting
branch
from
March 27, 2024 02:36
8f4554d
to
6e3d9a1
Compare
namchuai
changed the title
Feat/extension setting
feat: dynamically register extension settings
Mar 27, 2024
namchuai
force-pushed
the
feat/extension-setting
branch
2 times, most recently
from
March 27, 2024 08:08
36fd41a
to
e912297
Compare
@namchuai. I've updated the Settings API as discussed override async onLoad(): Promise<void> {
super.onLoad()
// Register Settings
this.registerSettings(SETTINGS)
// Retrieve API Key Setting
this.apiKey = await this.getSetting<string>(this.settingName, 'default_value_here')
}
// Update extension logic once setting is updated
onSettingUpdate<T>(key: string, value: T): void {
if (key === this.settingName) this.apiKey = value as string
} |
namchuai
force-pushed
the
feat/extension-setting
branch
from
March 28, 2024 07:04
94dd684
to
b002045
Compare
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
namchuai
force-pushed
the
feat/extension-setting
branch
from
March 28, 2024 17:44
08da8ff
to
410749b
Compare
louis-jan
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Screenshots
Self Checklist