Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce message request builder #2481

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Mar 24, 2024

Describe Your Changes

  • There is a lot of logic added to the sendChatMessage and resendMessage hooks, making it difficult to maintain and add new message types (currently limited to text, PDF, and image). It would be better to refactor them using Builders.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Sorry, something went wrong.

@github-actions github-actions bot added the type: chore Maintenance, operational label Mar 24, 2024
@louis-menlo louis-menlo requested review from namchuai and urmauur March 24, 2024 16:22
@louis-menlo louis-menlo force-pushed the chore/load-unload-model-sync branch from 24677e4 to 4faf6f0 Compare March 24, 2024 16:27
@louis-menlo louis-menlo force-pushed the chore/refactor-message-request-builder branch 6 times, most recently from 4115e33 to d9160a4 Compare March 24, 2024 16:54
@louis-menlo louis-menlo force-pushed the chore/load-unload-model-sync branch from 4faf6f0 to ec3196d Compare March 25, 2024 04:17
@louis-menlo louis-menlo force-pushed the chore/refactor-message-request-builder branch from d9160a4 to 4f9cd25 Compare March 25, 2024 04:20
@louis-menlo louis-menlo force-pushed the chore/load-unload-model-sync branch 2 times, most recently from 4df4851 to 9551996 Compare March 25, 2024 05:25
@louis-menlo louis-menlo force-pushed the chore/refactor-message-request-builder branch from 4f9cd25 to 67002a8 Compare March 25, 2024 05:26
@louis-menlo louis-menlo merged commit d9c8ff8 into chore/load-unload-model-sync Mar 25, 2024
@louis-menlo louis-menlo deleted the chore/refactor-message-request-builder branch March 25, 2024 05:27
@louis-menlo louis-menlo mentioned this pull request Apr 24, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants