Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error copy when model is too big - OOM #2250

Closed
wants to merge 1 commit into from
Closed

fix: error copy when model is too big - OOM #2250

wants to merge 1 commit into from

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Since there is no clear error code or response from llama.cpp and nitro, this is a quick fix for the case where the error output

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Mar 5, 2024
@louis-jan louis-jan requested a review from urmauur March 5, 2024 14:40
@louis-jan
Copy link
Contributor Author

Self-QA attempt failed, will get back with an update.

@louis-jan louis-jan marked this pull request as draft March 8, 2024 03:09
@louis-jan louis-jan force-pushed the fix/error-copy-when-model-is-too-big branch from 133a83b to 7da7e3a Compare March 27, 2024 15:14
@louis-jan louis-jan force-pushed the fix/error-copy-when-model-is-too-big branch from 7da7e3a to b8bf4fd Compare March 28, 2024 03:37
@louis-jan louis-jan closed this Mar 28, 2024
@louis-jan louis-jan deleted the fix/error-copy-when-model-is-too-big branch April 3, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @urmauur