Feat/python engine #1784
Open
Feat/python engine #1784
+1,940
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/python-engine
… feat/python-engine
… feat/python-engine
namchuai
reviewed
Dec 27, 2024
namchuai
reviewed
Dec 28, 2024
| @@ -374,6 +374,9 @@ void DownloadService::ProcessTask(DownloadTask& task, int worker_id) { | |||
| CTL_ERR("Failed to init curl!"); | |||
| return; | |||
| } | |||
| if (!std::filesystem::exists(item.localPath.parent_path())) { | |||
There was a problem hiding this comment.
I think the component which use download service will need to ensure the parent folder to be exists. Download service should not worry about create directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues