Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty engine name while install #1193

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: empty engine name while install #1193

merged 1 commit into from
Sep 11, 2024

Conversation

namchuai
Copy link
Collaborator

Describe Your Changes

  • Fix an error while running engine install. It's by capture by ref.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai marked this pull request as ready for review September 11, 2024 09:21
@namchuai namchuai merged commit c67d281 into dev Sep 11, 2024
4 checks passed
@namchuai namchuai deleted the j/fix-install-engine-empty-engine-name branch September 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @vansangpfiev