Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use string to guarantee lifetime #1192

Closed
wants to merge 1 commit into from
Closed

fix: use string to guarantee lifetime #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions engine/controllers/command_line_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,14 @@ bool CommandLineParser::SetupCommand(int argc, char** argv) {
auto install_cmd = engines_cmd->add_subcommand("install", "Install engine");
install_cmd->callback([] { CLI_LOG("Engine name can't be empty!"); });
for (auto& engine : engine_service_.kSupportEngines) {
std::string engine_name{engine};
EngineInstall(install_cmd, engine_name, version);
EngineInstall(install_cmd, engine, version);
}

auto uninstall_cmd =
engines_cmd->add_subcommand("uninstall", "Uninstall engine");
uninstall_cmd->callback([] { CLI_LOG("Engine name can't be empty!"); });
for (auto& engine : engine_service_.kSupportEngines) {
std::string engine_name{engine};
EngineUninstall(uninstall_cmd, engine_name);
EngineUninstall(uninstall_cmd, engine);
}

EngineGet(engines_cmd);
Expand Down
2 changes: 1 addition & 1 deletion engine/services/engine_service.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ struct EngineInfo {

class EngineService {
public:
const std::vector<std::string_view> kSupportEngines = {
const std::vector<std::string> kSupportEngines = {
"cortex.llamacpp", "cortex.onnx", "cortex.tensorrt-llm"};

EngineInfo GetEngineInfo(const std::string& engine) const;
Expand Down
Loading