Convert to pure WebExtension and further refactorings/fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such handlers should either return a boolean or a Promise. Use the an immediately resolved Promise in case of the synchronously handled clipboardWrite message. Return false if no message was handled. Reported by John Bieling. Signed-off-by: Jan Kiszka <[email protected]>
Allows to load ES6 modules from the script which we will use soon. Signed-off-by: Jan Kiszka <[email protected]>
This was introduced in TB 106 and backported to 102.4 (actually 102.3.3, but that is not a legal for struct_min_version). Using this allows to drop the open-coded tab lookup. Based on changes suggested by John Bieling. Signed-off-by: Jan Kiszka <[email protected]>
This will be used by the upcoming migration to an Experiment-free message processing. The modules needs one patch right now: "this" is undefined at top-level when a script is loaded as module, see [1]. Upstream PR will be sent. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/this Signed-off-by: Jan Kiszka <[email protected]>
Use browser.messages.getFull() to obtain the selected message and then parse the message, also with the help of the newly added email-addresses module. The interface between content and background scripts remain the same. Based on original conversion by John Bieling. Signed-off-by: Jan Kiszka <[email protected]>
With the Experiment API gone, we can drop strict_max_version, reducing future maintenance efforts. Signed-off-by: Jan Kiszka <[email protected]>
Now that the project is hosted and discussed there, let's move it officially. Signed-off-by: Jan Kiszka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work by @jobisoft, superseding #1.