Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language directories in _data and wiki to .gitignore #1040

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

softins
Copy link
Member

@softins softins commented Sep 11, 2024

Short description of changes

Add the non-English translation directories from _data and wiki into .gitignore

Context: Fixes an issue? Related issues

Once translations have been run on a dev system, all the non-English dirs in _data and wiki are flagged by git status.
This just ignores them to make the output tidier. It will also prevent them accidentally being added to a commit by git add.

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Does this need translation?
No

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

Only en and en-no-translate are committed to Github
@pljones
Copy link
Contributor

pljones commented Sep 11, 2024

Is this targeting 3.11.0? If so, please add to the board.

@softins softins added this to the Release 3.11.0 milestone Sep 11, 2024
@softins
Copy link
Member Author

softins commented Sep 11, 2024

Is this targeting 3.11.0? If so, please add to the board.

I assume you meant add the milestone. It may as well go into the web update for 3.11.0, as it's small, non-invasive and just makes working tidier.

@pljones
Copy link
Contributor

pljones commented Sep 11, 2024

I meant the project tracking board:
https://github.com/orgs/jamulussoftware/projects/5/views/5

@softins
Copy link
Member Author

softins commented Sep 11, 2024

OK I think I've added it right. Haven't used the project board before.

.gitignore Show resolved Hide resolved
@ann0see ann0see self-requested a review September 12, 2024 09:06
@softins softins merged commit 141802a into jamulussoftware:next-release Sep 12, 2024
1 check passed
@softins softins deleted the update-gitignore branch September 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants