Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rexml upgrade again #1001

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Apply rexml upgrade again #1001

merged 4 commits into from
Jul 28, 2024

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Jul 27, 2024

Got another PR from dependabot which should be merged to next-release

dependabot bot and others added 2 commits July 27, 2024 21:32
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.2.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.2.8...v3.3.2)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@pljones
Copy link
Contributor

pljones commented Jul 28, 2024

Closing as duplicate of #1000

@pljones pljones closed this Jul 28, 2024
@ann0see
Copy link
Member Author

ann0see commented Jul 28, 2024

The next-release branch needs to be updated.

@pljones pljones reopened this Jul 28, 2024
@pljones
Copy link
Contributor

pljones commented Jul 28, 2024

Oh I see. Is there anything blocking this happening?

@ann0see
Copy link
Member Author

ann0see commented Jul 28, 2024

Yes. I think automation doesn’t work since we haven’t white listed some outdated dependencies. And there are conflicts here.

@ann0see ann0see marked this pull request as ready for review July 28, 2024 12:57
@ann0see
Copy link
Member Author

ann0see commented Jul 28, 2024

Probably we‘ll just need to update the lock file locally on a PC.
The site is ok despite the build error.

@ann0see
Copy link
Member Author

ann0see commented Jul 28, 2024

Ok. Updated the lock file on PC. Will also need some update of the ruby version - but this should happen on next-release.

@ann0see ann0see merged commit 1dd5542 into next-release Jul 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants