Added convenience overload for push_back_decimal. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @skuzniar . I'll think about it. |
jamesdbrock
reviewed
Apr 8, 2024
| @@ -724,7 +724,7 @@ class message_writer { | |||
| * \throw std::out_of_range When the remaining buffer size is too small. | |||
| * \throw std::logic_error When called more than once for a single message. | |||
| */ | |||
| void push_back_header(char const* begin_string_version) { | |||
| size_t push_back_header(char const* begin_string_version) { | |||
There was a problem hiding this comment.
Are you using these size_t return values in your application? What are you doing with them?
There was a problem hiding this comment.
Ooops, I did not mean it to be a part of the original pull request. I understand it is a big change that you may not want. I should have do it on a different branch.
I am actually using the return values to create partial skeleton messages that I later update with information that changes - for example Price and Quantity, with the rest remaining the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite useful with functions that split floating point number into mantissa and exponent and returning the result as a tuple.
writer.push_back_decimal(hffix::tag::Price, split(price));