Fix to allow forceremove on users that have left a channel #1354
+36
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow DJs to remove users even when requesters have left the voice channel. Removed code pertaining to removal of multiple users requests due to that infrastructure never being used. Added parsing code to identify a User by id, mention, or username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
Added calls to bot.JDA to retrieve a discord User object with the aim to allow DJs to remove users even when requesters have left the voice channel. Removed code pertaining to removal of multiple users requests when calling forceremove. Added parsing code to identify a User by id, mention, or username. Note that with this change calling forceremove via username will still fail if the user has left the voice channel (due to how JDA.getUserTag) is implemented) but calling forceremove with either id or mention will now correctly delete that user's requests, regardless of if they are still in the channel or server in which they originally made that request.
Purpose
This request was created to solve Issue #1249
Relevant Issue(s)
This PR closes issue #1249