Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rocky to list of rhel-based distros for configuration defaults #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrichins
Copy link

Description

Found that when trying to use this cookbook while experimenting with rocky linux it fails for a null value being passed to a resource (I.e. its name value). This PR just fixes the case where a node's platform is rocky

Context

When using the library methods for getting default values for the osquery_daemon, osquery_config_path, osquery_packs_path and osquery_file_group there is a switch statement on the nodes ohai defined platform value.

And so for any platform outside of centos , ubuntu, redhat, and amazon distributions there is no value passed to the underlying resources such as here

While it is possible to override the functions to variables when using the cookbook resource directly, doing so does not appear to override the rest of the methods internally and so I've just updated the functions to provide the same response for rocky as it would for any of the other distributions.

Additionally it might be nice to default to a sane value in cases where the platform does not match, but I am not sure what a goo value for that might be, or if it would be better to just throw a named error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant