Restores default scrolling action onReset #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When zoomed all the way back out, allows user to return to known work-flow of scrolling down the page. Scrolling up will still trigger as normal. Tested. Also means that an image won't block a normal scroll use of the page when user isn't interested in zooming, but the image happens to be beneath the mouse (downwards scrolling had no effect on page when image was beneath cursor). Change only uses API function: http://api.jquery.com/scrolltop/ 60 is in pixels, so needs to be enough that it doesn't affect the normal use of the wheel.
| }(window.jQuery); |
There was a problem hiding this comment.
Hmm, I didn't intend this carriage return, must be the github online editor doing that.
|
Thanks. I think this is a good suggestion, but I don't really care for the way it's being implemented (no offense intended!). I think it was a bad idea on my part to tie to the normal onscroll, rather than having to activate it in some way (such as with a click or focus). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When zoomed all the way back out, allows user to return to known work-flow of scrolling down the page.
Scrolling up will still trigger as normal. Tested.
Also means that an image won't block a normal scroll use of the page when user isn't interested in zooming, but the image happens to be beneath the mouse (downwards scrolling had no effect on page when image was beneath cursor).
Change only uses API function: http://api.jquery.com/scrolltop/
60 is in pixels, so needs to be enough that it doesn't affect the normal use of the wheel.