add ability to use ':' in named args #2178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoNekoD
commented
Dec 1, 2024
| case ':': | ||
| nextRune, _ := utf8.DecodeRuneInString(l.src[l.pos:]) | ||
| prevRune := rune(0) | ||
| if l.pos > 1 { |
There was a problem hiding this comment.
I added this check to avoid panic when : is at the beginning of a line.
KoNekoD
commented
Dec 1, 2024
| if l.pos > 1 { | ||
| prevRune, _ = utf8.DecodeRuneInString(l.src[l.pos-2:]) | ||
| } | ||
| if nextRune != ':' && prevRune != ':' && (isLetter(nextRune) || nextRune == '_') { |
There was a problem hiding this comment.
It seems to me that we can omit the first check nextRune != ':' as there will be a more specific check next, but in addition I would like to say that this check is much easier than the next ones, and will cut off cast types a little faster.... But type casts are not done so often to leave this prevenient check.
What do you think, should I remove nextRune != ':' && ?
KoNekoD
commented
Dec 1, 2024
Comment on lines
+117
to
+121
| if l.pos-l.start > 0 { | ||
| l.parts = append(l.parts, l.src[l.start:l.pos-width]) | ||
| } | ||
| l.start = l.pos | ||
| return namedArgState |
KoNekoD
commented
Dec 1, 2024
| @@ -160,3 +160,155 @@ func TestStrictNamedArgsRewriteQuery(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestNamedArgsRewriteQuery2(t *testing.T) { | |||
There was a problem hiding this comment.
I also added a tests that should confirm the clarity of my implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.