Fix PSR16 compatibility by sanitizing Colon symbol

[alexander-schranz]

See sulu/sulu#7394

[alexander-schranz]

@dbu I'm not sure how we can keep the functional test for the CacheClient here correctly as the dependency graph seems hard to control what is compatible with the specific symfony cache.

[dbu]

thanks for this. kinda weird how many characters are not allowed in the key. psr-16 specifially forbids {}()/\@: and says at minimum A-Z, a-z, 0-9, _, and . must be supported. we should probably transliterate everything onto the minimal characeter set. we could use urlencode and then replace % with _. having an explicit list of allowed things is better than escaping specific things and then the next person comes with a node with 🛩️ in its name and some cache not happy with that.

RE simple-cache version: that is indeed unfortunate. it seems symfony 5 had psr-16 only as dev-dependency and thats the reason why composer does not know this won't work.

as this is the legacy 1.x branch, i propose we specifically do a composer require "psr/simple-cache:2.*" in the test-application.yaml file if php-version is equal to 8.0.

not super elegant, but its a bit of an edge case and not the reponsiblity of jackalope-doctrine-dbal .

want to do that?

[alexander-schranz]

@dbu urlencode does not catch . so we need to replace atleast that character manually. I pushed a version and adopted the testcase.

[dbu]

@dbu urlencode does not catch . so we need to replace atleast that character manually. I pushed a version and adopted the testcase.

right. according to https://www.php.net/manual/en/function.urlencode.php that should be the only mismatch, right?

[alexander-schranz]

@dbu I think so.

[dbu]

thanks a lot! squashed and added changelog entries in #448