Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanitizeKey to "workspace: " cache key #437

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add sanitizeKey to "workspace: " cache key #437

merged 2 commits into from
Jan 30, 2024

Conversation

alexander-schranz
Copy link
Contributor

I stumbled over this in: #436

dbu
dbu approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, if our workspace names can contain characters that are not sane as cache keys we need this.

@dbu dbu merged commit 456e83c into jackalope:1.x Jan 30, 2024
@dbu
Copy link
Member

dbu commented Jan 30, 2024

https://github.com/jackalope/jackalope-doctrine-dbal/releases/tag/1.11.2

@dbu
Copy link
Member

dbu commented Jan 30, 2024

merged to 2.x in #438, if you want to rebase the dbal 4 branch

@alexander-schranz alexander-schranz deleted the patch-2 branch January 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @dbu