Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding return types to commands #427

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Adding return types to commands #427

merged 1 commit into from
Oct 4, 2023

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Oct 2, 2023

Not specifying that the configure function is void is deprecated.

dbu
dbu approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have missed this when cleaning up the code for version 2. thanks a lot for spotting!

@dbu dbu merged commit 7845a12 into jackalope:2.x Oct 4, 2023
15 checks passed
@mamazu mamazu deleted the correct_typing branch October 4, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamazu @dbu