-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Versioning Support #316
base: 2.x
Are you sure you want to change the base?
Conversation
What's the status of this feature? |
i am waiting for @danrot to find time to continue on this. would indeed be nice to wrap this up and get it merged. |
"phpcr/phpcr-utils": "^1.2.8", | ||
"jackalope/jackalope": "~1.2.6" | ||
"phpcr/phpcr-utils": "dev-versioning as 1.2.9", | ||
"jackalope/jackalope": "dev-versioning as 1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when ready, merge and release jackalope/jackalope#296 and then require versions that have that code.
We're currently evaluating sulu.io as a possible CMS solution. I found that Sulu only supports Content Versioning when using Apache Jackrabbit, due to Jackalope not supporting it when using Doctrine DBAL. Are there any plans getting this merged? It seems this PR (and jackalope/jackalope#296) is pretty much abandoned. What are the blockers of getting it in? |
@RafaelKr I can only provide my perspective: I am not using Jackalope anymore, therefore I hope you can understand that I am not investing more time into this. |
and from the maintainer perspective: i am happy to review, but do not have the capacity to implement the functionality (dan did a good start, but afaik there is still a bunch of work to do to complete the implementation) |
Thanks for your fast feedback! I just got the response from the sulu maintainers, that they plan to move away from PHPCR (and so also from jackalope) with v3.0 – with versioning already included out of the box. So at least to me the feature isn't that relevant anymore. Sorry for bothering. |
depends on jackalope/jackalope#296