[WIP] Cache queries node types #281
Conversation
| @@ -147,10 +205,14 @@ public function getAccessibleWorkspaceNames() | |||
| */ | |||
| public function getNode($path) | |||
| { | |||
| if (empty($this->caches['nodes'])) { | |||
| return parent::getNode($path); | |||
There was a problem hiding this comment.
then how will this ever get cached?
There was a problem hiding this comment.
correct .. but the Client should also do any real work for this either .. so I figured its faster to do it like this, than to even bother to look at the cache backend.
There was a problem hiding this comment.
actually misread this .. I made this change since in theory a user can have no caching for nodes active.
There was a problem hiding this comment.
also this change is actually part of #280
to review this maybe better to look at cache_queries...cache_queries_node_types
There was a problem hiding this comment.
i think i understand now. but anyway, i will wait for #280 to be merged and then we can rebase this one. will make it easier to review.
lsmith77
force-pushed
the
cache_queries_node_types
branch
2 times, most recently
from
5c6691c to
c8c4c63
Compare
lsmith77
force-pushed
the
cache_queries_node_types
branch
from
c8c4c63 to
578f599
Compare
|
needs a rebase now that #280 is merged. |
includes #280, requires jackalope/jackalope#287
so for review maybe easier to look at cache_queries...cache_queries_node_types