Copy references #236
Merged
Copy references #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase |
- New column "numerical_props" which is populated by numerical properies and which is used exlusively for ordering.
dantleech
force-pushed
the
copy_references
branch
3 times, most recently
from
f4afc1e to
3a7cc80
Compare
| $referenceEls = $xpath->query('.//sv:property[@sv:type="reference"]'); | ||
|
|
||
| foreach ($referenceEls as $referenceEl) { | ||
| if (array_key_exists($referenceEl->nodeValue, $resultSetUuids)) { |
There was a problem hiding this comment.
Should use isset here I think.
dantleech
force-pushed
the
copy_references
branch
from
3a7cc80 to
c73cc61
Compare
|
Rebased and updated the related phpcr-api-tests PR. |
|
can you rebase once more? |
|
@lsmith77 the branch is already up-to-date here |
|
yes .. but if you rebase to master then the tests should pass |
|
I will restart the tests .. but I can't rebase on master because there is nothing to rebase on. |
|
All green :) |
|
i wrote a comment on phpcr/phpcr-api-tests#148 - can you check that? would love to merge the tests first, then restart this build one more time, just to be sure. |
|
merged the tests and restarted the build |
|
Last test run failed with the random problem (cannot delete node |
|
Build is green now however ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is based on the numerical sorting PR (#226) which would need to be merged first.
If that PR is rejected I will need to rebase and update this PR, probably better to delay reviewing this until that is merged.
For changes see the second commit in this PR.
Depends