fix issue with SQLite and chunking of parameters

jackalope · May 2, 2015 · f043906 · f043906
1 parent 70a7095
commit f043906
Showing 1 changed file with 22 additions and 15 deletions.
diff --git a/src/Jackalope/Transport/DoctrineDBAL/Client.php b/src/Jackalope/Transport/DoctrineDBAL/Client.php
@@ -525,6 +525,25 @@ public function getNamespaces()
         return $this->namespaces;
     }
 
+    /**
+     * Executes an UPDATE on DBAL while ensuring that we never try to send more than 999 parameters to SQLite
+     *
+     * @param $query
+     * @param array $params
+     * @param array $types
+     * @throws DBALException
+     */
+    private function executeUpdate($query, array $params = array(), array $types = array())
+    {
+        if ($this->conn->getDatabasePlatform() instanceof SqlitePlatform) {
+            foreach (array_chunk($params, 999) as $chunk) {
+                $this->conn->executeUpdate($query, array($chunk), $types);
+            }
+        } else {
+            $this->conn->executeUpdate($query, array($params), $types);
+        }
+    }
+
     /**
      * {@inheritDoc}
      */
@@ -729,7 +748,7 @@ private function syncReferences()
             try {
                 foreach ($this->referenceTables as $table) {
                     $query = "DELETE FROM $table WHERE source_id IN (?)";
-                    $this->conn->executeUpdate($query, array(array_keys($toUpdate)), array(Connection::PARAM_INT_ARRAY));
+                    $this->executeUpdate($query, array(array_keys($toUpdate)), array(Connection::PARAM_INT_ARRAY));
                 }
             } catch (DBALException $e) {
                 throw new RepositoryException('Unexpected exception while cleaning up after saving', $e->getCode(), $e);
@@ -765,13 +784,7 @@ private function syncReferences()
             // remove all PropertyType::REFERENCE with a source_id on a deleted node
             try {
                 $query = "DELETE FROM phpcr_nodes_references WHERE source_id IN (?)";
-                if ($this->conn->getDatabasePlatform() instanceof SqlitePlatform) {
-                    foreach (array_chunk($params, 999) as $chunk) {
-                        $this->conn->executeUpdate($query, array($chunk), array(Connection::PARAM_INT_ARRAY));
-                    }
-                } else {
-                    $this->conn->executeUpdate($query, array($params), array(Connection::PARAM_INT_ARRAY));
-                }
+                $this->executeUpdate($query, array($params), array(Connection::PARAM_INT_ARRAY));
             } catch (DBALException $e) {
                 throw new RepositoryException('Unexpected exception while cleaning up deleted nodes', $e->getCode(), $e);
             }
@@ -810,13 +823,7 @@ private function syncReferences()
             try {
                 foreach ($this->referenceTables as $table) {
                     $query = "DELETE FROM $table WHERE target_id IN (?)";
-                    if ($this->conn->getDatabasePlatform() instanceof SqlitePlatform) {
-                        foreach (array_chunk($params, 999) as $chunk) {
-                            $this->conn->executeUpdate($query, array($chunk), array(Connection::PARAM_INT_ARRAY));
-                        }
-                    } else {
-                        $this->conn->executeUpdate($query, array($params), array(Connection::PARAM_INT_ARRAY));
-                    }
+                    $this->executeUpdate($query, array($params), array(Connection::PARAM_INT_ARRAY));
                 }
             } catch (DBALException $e) {
                 throw new RepositoryException('Unexpected exception while cleaning up deleted nodes', $e->getCode(), $e);