Skip to content

Commit

Permalink
Merge pull request #306 from andylibrian/type-hint-issue-registerSqli…
Browse files Browse the repository at this point in the history
…teFunctions

Loosen type hint from DBAL PDOConnection to simply PDO object
  • Loading branch information
dbu committed Oct 20, 2015
2 parents f9aceb2 + a4fd531 commit 5bea743
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/Jackalope/Transport/DoctrineDBAL/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
use PHPCR\Util\UUIDHelper;
use PHPCR\Util\PathHelper;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Platforms\PostgreSqlPlatform;
use Doctrine\DBAL\Platforms\SqlitePlatform;
Expand Down Expand Up @@ -204,11 +203,11 @@ public function __construct(FactoryInterface $factory, Connection $conn)
/**
* @TODO: move to "SqlitePlatform" and rename to "registerExtraFunctions"?
*
* @param PDOConnection $sqliteConnection
* @param \PDO $sqliteConnection
*
* @return Client
*/
private function registerSqliteFunctions(PDOConnection $sqliteConnection)
private function registerSqliteFunctions(\PDO $sqliteConnection)
{
$sqliteConnection->sqliteCreateFunction('EXTRACTVALUE', function ($string, $expression) {
if (null === $string) {
Expand Down

0 comments on commit 5bea743

Please sign in to comment.