Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel solo routing signal to direct out of other channels #104

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

SpotlightKid
Copy link
Contributor

@SpotlightKid SpotlightKid commented Feb 10, 2021

  • Added comments for better orientation in backend signal processing code.
  • Fixed signal routing of soloed channels: do not mix them into system channels,
    i.e. direct and monitoring outs (unless, of course, they are soloed for that
    specific output, which is true for the direct out of that particular channel
    or the monitor out, if monitoring is enabled on that particular channel).

Fixes: #96

@SpotlightKid SpotlightKid force-pushed the bugfix/96-solo-routing branch from 4c67712 to c17b764 Compare February 10, 2021 23:37
@SpotlightKid SpotlightKid changed the title [WIP] Fix channel solo routing signal to direct out of other channels Fix channel solo routing signal to direct out of other channels Feb 10, 2021
@SpotlightKid SpotlightKid marked this pull request as ready for review February 10, 2021 23:38
@SpotlightKid SpotlightKid merged commit 9aeec89 into jack-mixer:main Feb 10, 2021
@SpotlightKid SpotlightKid deleted the bugfix/96-solo-routing branch February 10, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solo feature is not working as expected
1 participant