Register new CName / CName as Hash #41

Roms1383 · 2023-12-27T10:08:01Z

This small PR adds:

the necessary conversion to use CName as std::hash::Hash (via newtype pattern)
the ability to safely register new CName in underlying CNamePool

Wishing you happy end of the year's celebrations @jac3km4 :)

allows to use std::hash:Hash with newtype pattern over CName

red4ext-sys/cpp/glue/glue.hpp

red4ext-sys/src/interop.rs

also renamed according to IsNameValid (cyberdoc)

red4ext-sys/src/interop.rs

Co-authored-by: jac3km4 <[email protected]>

Roms1383 added 3 commits December 27, 2023 15:46

Convert CName from/to u64

98283ba

allows to use std::hash:Hash with newtype pattern over CName

Add method to register new CName

1801fea

Lint code

971b1bb

jac3km4 reviewed Dec 27, 2023

View reviewed changes

red4ext-sys/cpp/glue/glue.hpp Outdated Show resolved Hide resolved

jac3km4 reviewed Dec 27, 2023

View reviewed changes

red4ext-sys/src/interop.rs Outdated Show resolved Hide resolved

jac3km4 reviewed Dec 27, 2023

View reviewed changes

red4ext-sys/src/interop.rs Outdated Show resolved Hide resolved

Roms1383 added 5 commits December 28, 2023 00:03

Check CName exists in Rust

d60c286

also renamed according to IsNameValid (cyberdoc)

Handle None for CName

85db0ae

More idiomatic conversion from CName to u64

6f37157

Add check for None in CName new

7d4a2a8

Rename CName add to new_pooled

6cfe372

jac3km4 reviewed Dec 27, 2023

View reviewed changes

red4ext-sys/src/interop.rs Outdated Show resolved Hide resolved

Roms1383 and others added 4 commits December 28, 2023 00:51

Add unit-test for CName new with empty string

e7171d2

Refactor check for None in CName new

cc75355

Co-authored-by: jac3km4 <[email protected]>

Lint code

4c37adf

Add annotations to CName functions

b509675

jac3km4 merged commit d2d7713 into jac3km4:master Dec 27, 2023
4 checks passed

Roms1383 deleted the feat/register-cname branch December 28, 2023 01:01

Provide feedback