-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic IScriptable methods #39
Conversation
I haven't tested it yet, will do tomorrow. |
I realize though it's convenient when inheriting for a couple of classes but far from optimal when using tons: each call to That being said, having this implementation on What do you think, should I drop this PR ? |
@jac3km4 could you give me your opinion on whether this feature is worth finishing ? |
Some suggestions:
|
Co-authored-by: jac3km4 <[email protected]>
This small PR adds
IScriptable
most basic methods :GetClassName
IsA
IsExactlyA
to avoid having to create a newtype pattern like so:
especially when deriving children classes like so: