Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead comments from gradle files #2291

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

8Keep
Copy link
Contributor

@8Keep 8Keep commented Jul 6, 2024

Deleting some dead code here to simplify the gradle files.

@8Keep
Copy link
Contributor Author

8Keep commented Jul 7, 2024

Reverted changes to jme3-examples build file

@8Keep 8Keep merged commit 89000af into jMonkeyEngine:master Jul 7, 2024
1 check passed
@stephengold
Copy link
Member

Thank you, @8Keep.
The rest of the dead comments are mysteries to me.
Have you looked at the commits that added them, to understand why they're there?

@8Keep
Copy link
Contributor Author

8Keep commented Jul 8, 2024

The ones I left in this commit were last changed 10+ years ago, I am pretty sure they were just left by the authors

@stephengold
Copy link
Member

You're probably right! Thanks.

@stephengold stephengold added buildscript An issue with the buildscript Documentation Issues that affect the Wiki, Javadoc or any other form of documentation labels Oct 22, 2024
@stephengold stephengold added this to the Future Release milestone Oct 22, 2024
@yaRnMcDonuts yaRnMcDonuts modified the milestones: Future Release, v3.8.0 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildscript An issue with the buildscript Documentation Issues that affect the Wiki, Javadoc or any other form of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants