Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #2220

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open
Original file line number Diff line number Diff line change
Expand Up @@ -1398,7 +1398,7 @@ assert isValidNumber(fb) : "Invalid Matrix4f value " + uniform.getValue() + " fo
case FloatArray:
fb = uniform.getMultiData();
assert isValidNumber(fb) : "Invalid float array value "
+ Collections.singletonList((float[]) uniform.getValue()) + " for " + uniform.getBinding();
+ Arrays.toString((float[]) uniform.getValue()) + " for " + uniform.getBinding();
gl.glUniform1(loc, fb);
break;
case Vector2Array:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,17 @@ public void onAction(String name, boolean ongoing, float ignored) {
*/
if (name.equals("left")) {
angle += 0.1f; // radians
System.out.print("rotate floor and sky leftward ...");
System.out.println("rotate floor and sky leftward ...");
} else if (name.equals("right")) {
angle -= 0.1f; // radians
System.out.print("rotate floor and sky spatials rightward ...");
System.out.println("rotate floor and sky spatials rightward ...");
} else {
return;
}
/*
* Update the local rotations of both objects based on the angle.
*/
System.out.printf(" to %.1f radians left of start%n", angle);
stephengold marked this conversation as resolved.
Show resolved Hide resolved
System.out.printf(" to %.1f radians left of start%n\n", angle);
Quaternion rotation = new Quaternion();
rotation.fromAngleNormalAxis(angle, Vector3f.UNIT_Y);
floor.setLocalRotation(rotation);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ public int[] getPorts() {

@Override
public String toString() {
return "ChannelInfoMessage[" + id + ", " + Collections.singletonList(ports) + "]";
return "ChannelInfoMessage[" + id + ", " + Arrays.toString(ports) + "]";
}
}
Loading