Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using deprecated FrameBuffer methods in jme3-examples #1554

Open
stephengold opened this issue May 13, 2021 · 2 comments · May be fixed by #1616
Open

Using deprecated FrameBuffer methods in jme3-examples #1554

stephengold opened this issue May 13, 2021 · 2 comments · May be fixed by #1616
Assignees
@riccardobl
Labels
examples specific to the jme3-examples sub-project
Milestone
Future Release

Comments

@stephengold
Copy link
Member

stephengold commented May 13, 2021 •
edited
Loading

PR #1401 deprecated the addColorTexture(Texture2D), setColorBuffer(Format), setColorTexture(Texture2D), setDepthBuffer(Format), and setDepthTexture(Texture2D) methods of FrameBuffer. However those methods are still used in jme3-examples.

As noted at #1401, it is difficult to understand how the replacement methods are meant to be used. Let's upgrade jme3-examples to use the new interface.
@stephengold stephengold added this to the Future Release milestone May 13, 2021
@riccardobl
Copy link
Member

I've started converting the examples and added a quick documentation here: #1616 .

@stephengold
Copy link
Member Author

Thanks @riccardobl

@stephengold stephengold added the examples specific to the jme3-examples sub-project label Nov 10, 2021
@stephengold stephengold mentioned this issue Nov 16, 2021
Closed
@stephengold stephengold changed the title avoid using deprecated FrameBuffer methods in jme3-examples Using deprecated FrameBuffer methods in jme3-examples Nov 16, 2021
@stephengold stephengold modified the milestones: Future Release, v3.5.0 Dec 2, 2021
@stephengold stephengold linked a pull request Dec 2, 2021 that will close this issue
Update examples to use new framebuffer apis #1616
Draft
@stephengold stephengold modified the milestones: v3.5.0, Future Release Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riccardobl riccardobl

Labels
examples specific to the jme3-examples sub-project
Projects
None yet
Milestone
Future Release
Development

Successfully merging a pull request may close this issue.

Update examples to use new framebuffer apis riccardobl/jmonkeyengine
2 participants
@stephengold @riccardobl